fix: use memset in bitset_set and bitset_clear#148
Merged
spaskalev merged 1 commit intospaskalev:mainfrom Dec 5, 2025
Merged
Conversation
e13fc4a to
d96d058
Compare
Owner
|
Thanks. Can you make it |
Contributor
Author
|
yeah, just force pushed. Oh, do you prefer |
Owner
|
This works too :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
The current implementations of bitset_set_range and bitset_clear_range use while loops and set bytes individually. Often, the system's standard c library will include system-specific optimizations with memset.
Speedups are a lot more humble than my previous suggestion, but the implementation is cleaner!