-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suppliers Automation Direct and Jameco #248
Closed
hillsandales
wants to merge
23
commits into
sparkmicro:main
from
hillsandales:add-supplier-automationdirect
Closed
Add suppliers Automation Direct and Jameco #248
hillsandales
wants to merge
23
commits into
sparkmicro:main
from
hillsandales:add-supplier-automationdirect
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Inventree, Param map for Electronics does not exist warning. Part creation failed error, check Ki-nTree settings match Inventree part settings error msg.
…rs work with requests.get() and not urllib.request.urlopen()
Yup you did just that 😄 is this PR dependent on #247 ? |
I'll submit another pull request indicating both suppliers were added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also implemented search support for Automation Direct's website. It uses similar techniques as Jameco's in that the request is sent to the same API URL used for searching on Automation Direct's search box. Automation Direct search returns json data that is then used to populate the page. I've tested it on a few different types of parts, and it seems to return valid standard data and parameter data. Pricing data is also implemented, thought Automation Direct does not offer quantity discounts. For parts that do have quantity other than equal to 1, such as cable, it creates pricing data for a list of quantities that cable may be ordered. For parts that are sold individually, this min/max length for ordering is not returned, so it simply takes the 'price' value and puts it into the part_info['pricing'] dictionary as a quantity of 1.
It looks like I may have branched off from my Jameco branch that I submitted yesterday by mistake. This one appears to include both...