-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems with redirects for datasheet links #233
Conversation
Thanks @T0jan I'll have to review this a bit later 😄 |
@T0jan I won't have time to test but I have put a couple comments in your proposal. Also I need to figure out why the Mouser API is failing on |
Hello @T0jan I just tested it and it works well for downloading and attaching datasheet to parts on InvenTree. However there is also a feature to download the datasheet in a local folder and this part hasn't been updated and it fails the download: I think a more generalized approach and updating the download method in |
@eeintech you are right, completely forgot the local download in my try to keep the renaming and the redirect in one function, which is completely unnecessary. Moved the redirect part to the download function in |
Hello @T0jan I allowed myself to tackle one layer further in #246 |
@eeintech the first idea on how to tackle #207 and #230. I kept it really basic for now as I only discovered problems with TI parts in the last months, if you prefer a more sophisticated solution let me know