fix: IO handling in HTML4::DocumentFragment.parse #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharvy
force-pushed
the
2069-html4-document-fragment-io-parse
branch
from
34d50fa
to
4358f67
Compare
|
@sharvy Nice! Thank you for putting this together. I kicked off CI and will review as soon as I get a chance. ♥ |
|
@flavorjones The pleasure is absolutely mine! Thanks. |
flavorjones
approved these changes
Aug 5, 2024
Previously an exception (TypeError: no implicit conversion of File into String) would be raised. Fixes: sparklemotion#2069
flavorjones
force-pushed
the
2069-html4-document-fragment-io-parse
branch
from
1728541
to
2510bf6
Compare
|
@sharvy This looks good! I corrected some things in the doc string but otherwise this is great! Thank you! |
flavorjones
force-pushed
the
2069-html4-document-fragment-io-parse
branch
from
2510bf6
to
bdac6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Previously an exception (TypeError: no implicit conversion of File into String) would be raised.
Fixes: #2069
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
No.