Add regression test for circular require across load orders#67
Draft
lineoffligbot wants to merge 1 commit into
Draft
Add regression test for circular require across load orders#67lineoffligbot wants to merge 1 commit into
lineoffligbot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test that asserts no
circular requirewarning is emitted for any load order of the gem's entry points.Refs #66 (warning under
require "http/cookie_jar"; require "http/cookie", which is whatrequire "http"triggers viahttp/sessionprecedinghttp/response). This test also covers the scenarios fixed in #65.The test currently fails on scenario 4 (
http/cookie_jarthenhttp/cookie) on master, demonstrating #66. Opening as a draft — happy to adjust style/location, and I can follow up with a fix PR once you've confirmed a preferred direction in #66.Implementation notes:
Bundler.with_unbundled_envscrubsbundle exec's env injections so the child process doesn't pre-activate the installed gem (which masks the warning).