Merge pull request #166 from sparcs-kaist/issue/164/prevent-review-su…

…bmission-for-drop-period

fix: replaced hardcoded values

src/modules/auth/command/isReviewProhibited.command.ts

@@ -4,12 +4,14 @@ import { Reflector } from '@nestjs/core';
 import { AuthCommand, AuthResult } from '../auth.command';
 import { LecturesService } from '@src/modules/lectures/lectures.service';
 import { Request } from 'express';
+import { PrismaService } from '@src/prisma/prisma.service';
 
 @Injectable()
 export class IsReviewProhibitedCommand implements AuthCommand {
   constructor(
     private reflector: Reflector,
     private lectureService: LecturesService,
+    private prismaService: PrismaService,
   ) {}
 
   public async next(
@@ -22,6 +24,7 @@ export class IsReviewProhibitedCommand implements AuthCommand {
     );
 
     const request = context.switchToHttp().getRequest<Request>();
+    const requestTime = new Date();
     const reviewsBody = request.body;
 
     if (isReviewProhibited) {
@@ -32,10 +35,23 @@ export class IsReviewProhibitedCommand implements AuthCommand {
         const lecture = await this.lectureService.getLectureById(
           reviewsBody.lecture,
         );
-        // TODO: implement logic to replace hardcoded values
-        if (lecture.year == 2025 && lecture.semester == 1) {
+
+        const semester = await this.prismaService.subject_semester.findFirst({
+          where: {
+            AND: [{ year: lecture.year }, { semester: lecture.semester }],
+          },
+          select: {
+            courseDropDeadline: true,
+          },
+        });
+        if (!semester || !semester.courseDropDeadline) {
+          throw new Error('semester info are not found from request');
+        }
+
+        if (requestTime < semester.courseDropDeadline) {
           prevResult.authorization = false;
         }
+
         return Promise.resolve(prevResult);
       } catch (e) {
         console.log(e);