Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add PostRow and MainPageCard #13

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Conversation

KoYejune0302
Copy link
Contributor

@KoYejune0302 KoYejune0302 commented Apr 29, 2024

Description

Closes #5

This PR introduces the PostRow, TitledSection, and Card component.

image image

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ara-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:41am

@yumincho
Copy link
Member

atom 내에 Card와 관련된 컴포넌트들 구조를 파악하고 싶어서 스케치해봤습니다.

image

지금 컴포넌트를 조합하는 방식이 제게는 약간 불명확해보이는데, 약간의 디자인 수정을 거친다면 Post(== 현 CardContentRow)에 필요한 prop들을 아래와 같이 정리할 수 있을 것 같아요.

image
type PostRowProps = {
    title: stirng
    hasImage: boolean // default: false
    hasFile: boolean // default: false
    subInfo?: {
        responseStatus?: ResponseStatus
        board?: string
        author: string
        views?: number
        date?: Date
    }
    counts?: {
        likes: number
        dislikes: number
        comments: number
    }
    rank?: number
}

Post 내부 요소는 따로 분리하지 말고 하나로 묶으면 어떤가요? 돌아오는 회의에서 더 자세히 얘기해보면 좋겠습니다 👍

src/components/atoms/CardContent/CardContent.css.ts Outdated Show resolved Hide resolved
src/components/atoms/CardContent/CardContent.tsx Outdated Show resolved Hide resolved
src/components/atoms/PostRow/PostRow.css.ts Outdated Show resolved Hide resolved
src/components/atoms/PostRow/PostRow.css.ts Outdated Show resolved Hide resolved
src/constants/const.ts Outdated Show resolved Hide resolved
src/components/atoms/PostRow/PostRow.tsx Outdated Show resolved Hide resolved
src/components/atoms/PostRow/PostRow.tsx Outdated Show resolved Hide resolved
src/components/atoms/PostRow/PostRow.tsx Outdated Show resolved Hide resolved
@yumincho
Copy link
Member

yumincho commented May 22, 2024

@KoYejune0302

  1. 제가 하나하나 만들어서 테스트하기 어려워서.. @/app에 있는 page.tsx에 여러 케이스 구현해서 넣어주시면 좋을 것 같습니다. 그리고 그렇게 테스트 하다 보면 문제 되는 부분들을 찾기 더 쉬우실 거예요.
  2. 아직 코드에 못 본 부분들이 좀 있는데 위쪽 코멘트 반영하신 뒤에 핑 주시면 한 번에 보겠습니다 😂

@injoonH
Copy link
Member

injoonH commented Jul 11, 2024

Storybook을 추가하면서 바뀐 건지 subInfo 사이에 있던 ·가 사라졌습니다. @yumincho 확인해주실 수 있나요?

Comment on lines +123 to +127
globalStyle(`${subInfo} > span:not(:last-child)::after`, {
content: "·",
marginLeft: "0.5rem",
color: vars.color.neutralLight1,
});
Copy link
Member

@yumincho yumincho Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@injoonH 제 로컬에서는 요 이슈 재현이 안 되네요.. ㅜ.ㅜ 관련된 코드는 여기입니다

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add main page card
3 participants