concretization cache: use user input spec#52716
Merged
alalazo merged 2 commits intoJul 14, 2026
Merged
Conversation
haampie
force-pushed
the
hs/fix/conc-cache-user-input-spec
branch
2 times, most recently
from
f226c12 to
826d61b
Compare
This was referenced Jul 13, 2026
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
There is a pre-existing bug in JSON (de)serialization of abstract specs related to conditional specs like `mpileaks %[when='+shared'] c=gcc`, which loses the `when=...` condition. There's no technical reason that we should replace the abstract spec from the user with the deserialized one from the cache, so stop doing that. Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
hs/fix/conc-cache-user-input-spec
branch
from
826d61b to
acb0537
Compare
alalazo
approved these changes
Jul 14, 2026
alalazo
left a comment
alalazo
left a comment
Member
There was a problem hiding this comment.
Fair, the ASP input is authoritative, not the abstract spec serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for "Conditional specs do not round trip as dict #52720".
That issue should be fixed independently, but I don't see why
the concretization cache swaps the user input for the abstract spec
from a file. It feels like it could result in more subtle issues, so this
commit avoids possible future issues.