-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: drop EOL versions #33898
Python: drop EOL versions #33898
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2aee410
to
66f239e
Compare
@spackbot maintainers |
Second half: @hanwen-pcluste @jcbowden @jeanbez @jedbrown @jke513 @joseeroman @jppelteret @kwryankrattiger @lee218llnl @leiterrl @likask @liuyangzhuan @luca-heltai @lukeseawalker @marcusboden @matthiasdiener @mhaseeb123 @migueldiascosta @murray55 @mwkrentel @NessieCanCode @pcdslab @pfluegdk @pradyunsg @qobilidop @renjithravindrankannath @rgommers @robertu94 @robqiao @scemama @scheibelp @sethrj @shanedsnyder @skosukhin @smolins @snehring @srekolam @sshudler @svenevs @takluyver @tgaddair @trws @tzanio @v-dobrev @vicentebolea @vvolkl Can y'all review this PR? It modifies (or in many cases removes) a package for which you are listed as a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding the changes to the berkeleygw package, lgtm (I'll separately look into adding back the dependencies using python 3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed roctracer-dev and looks okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very good idea. I checked the packages I maintain: py-numpy
looks good, py-scipy
isn't touched in this PR. Not sure if that was intended; old versions can be dropped there as well.
69bbff9
to
32b3ace
Compare
This PR removes [end of life](https://endoflife.date/python) versions of Python from Spack. Specifically, this includes all versions of Python older than 3.7. See spack#31824 for rationale. Deprecated in spack#32615. And spack#28003. For anyone using software that relies on Python 2, you have a few options: * Upgrade the software to support Python 3. The `3to2` tool may get you most of the way there, although more complex libraries may need manual tweaking. * Add Python 2 as an [external package](https://spack.readthedocs.io/en/latest/build_settings.html#external-packages). Many Python libraries do not support Python 2, but you may be able to add older versions that did once upon a time. * Use Spack 0.19. Spack 0.19 is the last release to officially support Python 3.6 and older * Create and maintain your own [custom repository](https://spack.readthedocs.io/en/latest/repositories.html). Basically, you would need a package for Python 2 and any other Python 2-specific libraries you need.
@scheibelp As investigated during the Spack User meeting, this PR added a |
This PR removes end of life versions of Python from Spack. Specifically, this includes all versions of Python older than 3.7.
See #31824 for rationale. Deprecated in #32615. And #28003.
For anyone using software that relies on Python 2, you have a few options:
3to2
tool may get you most of the way there, although more complex libraries may need manual tweaking.