Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: drop EOL versions #33898

Merged
merged 18 commits into from
Nov 22, 2022
Merged

Conversation

adamjstewart
Copy link
Member

@adamjstewart adamjstewart commented Nov 14, 2022

This PR removes end of life versions of Python from Spack. Specifically, this includes all versions of Python older than 3.7.

See #31824 for rationale. Deprecated in #32615. And #28003.

For anyone using software that relies on Python 2, you have a few options:

  • Upgrade the software to support Python 3. The 3to2 tool may get you most of the way there, although more complex libraries may need manual tweaking.
  • Add Python 2 as an external package. Many Python libraries do not support Python 2, but you may be able to add older versions that did once upon a time.
  • Use Spack 0.19. Spack 0.19 is the last release to officially support Python 3.6 and older
  • Create and maintain your own custom repository. Basically, you would need a package for Python 2 and any other Python 2-specific libraries you need.

@haampie

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

@spackbot-app spackbot-app bot added conflicts maintainers stand-alone-tests Stand-alone (or smoke) tests for installed packages extends labels Nov 14, 2022
@adamjstewart
Copy link
Member Author

@spackbot maintainers

v-dobrev
v-dobrev previously approved these changes Nov 15, 2022
Copy link
Contributor

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the changes to the berkeleygw package, lgtm (I'll separately look into adding back the dependencies using python 3)

pradyunsg
pradyunsg previously approved these changes Nov 15, 2022
Copy link

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. :)

jedbrown
jedbrown previously approved these changes Nov 15, 2022
HadrienG2
HadrienG2 previously approved these changes Nov 15, 2022
srekolam
srekolam previously approved these changes Nov 15, 2022
Copy link
Contributor

@srekolam srekolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed roctracer-dev and looks okay to me.

BoboTiG
BoboTiG previously approved these changes Nov 15, 2022
joseeroman
joseeroman previously approved these changes Nov 15, 2022
marcusboden
marcusboden previously approved these changes Nov 15, 2022
apdavison
apdavison previously approved these changes Nov 15, 2022
rgommers
rgommers previously approved these changes Nov 15, 2022
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very good idea. I checked the packages I maintain: py-numpy looks good, py-scipy isn't touched in this PR. Not sure if that was intended; old versions can be dropped there as well.

@tgamblin tgamblin merged commit c5883ff into spack:develop Nov 22, 2022
@adamjstewart adamjstewart deleted the packages/python2 branch November 22, 2022 23:02
alalazo added a commit to alalazo/spack that referenced this pull request Nov 23, 2022
alalazo added a commit to alalazo/spack that referenced this pull request Nov 23, 2022
alalazo added a commit to alalazo/spack that referenced this pull request Dec 5, 2022
alalazo added a commit to alalazo/spack that referenced this pull request Dec 5, 2022
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
This PR removes [end of life](https://endoflife.date/python) versions of Python from Spack. Specifically, this includes all versions of Python older than 3.7.

See spack#31824 for rationale. Deprecated in spack#32615. And spack#28003.

For anyone using software that relies on Python 2, you have a few options:

* Upgrade the software to support Python 3. The `3to2` tool may get you most of the way there, although more complex libraries may need manual tweaking.
* Add Python 2 as an [external package](https://spack.readthedocs.io/en/latest/build_settings.html#external-packages). Many Python libraries do not support Python 2, but you may be able to add older versions that did once upon a time.
* Use Spack 0.19. Spack 0.19 is the last release to officially support Python 3.6 and older
* Create and maintain your own [custom repository](https://spack.readthedocs.io/en/latest/repositories.html). Basically, you would need a package for Python 2 and any other Python 2-specific libraries you need.
@skosukhin skosukhin mentioned this pull request Jul 13, 2023
@tldahlgren
Copy link
Contributor

@scheibelp As investigated during the Spack User meeting, this PR added a conflicts to qt+webkit that precludes building the only version of rstudio in the Spack package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.