Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IFU+datacubes docs page. #917

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Sep 27, 2024

  • Add a new docs page for JWST IFU + data cubes simulations. This functionality was included in the 1.4 release, but we didn't really document it well anywhere yet.
  • Also, fix minor nbsphinx formatting issue on the matching PSFs page, which was preventing the bulleted lists from rendering correctly in nbsphinx. A blank line is needed before the bulleted lists for nbsphinx to display them correctly.

@mperrin mperrin self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.15%. Comparing base (d39fa3d) to head (490d6bf).
Report is 42 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #917      +/-   ##
===========================================
+ Coverage    61.85%   62.15%   +0.30%     
===========================================
  Files           15       15              
  Lines         6945     7016      +71     
===========================================
+ Hits          4296     4361      +65     
- Misses        2649     2655       +6     
Flag Coverage Δ
62.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I ran the new notebook with no errors.

@obi-wan76 obi-wan76 merged commit 17c26f5 into spacetelescope:develop Sep 27, 2024
8 checks passed
@mperrin mperrin added the docs label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants