Add missing astroquery dependency

[larrybradley]

No description provided.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.75% ⚠️

Comparison is base (90dba3f) 55.94% compared to head (5250d16) 55.20%.

❗ Current head 5250d16 differs from pull request most recent head e1682e9. Consider uploading reports for the commit e1682e9 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #690      +/-   ##
===========================================
- Coverage    55.94%   55.20%   -0.75%     
===========================================
  Files           15       14       -1     
  Lines         6281     6141     -140     
===========================================
- Hits          3514     3390     -124     
+ Misses        2767     2751      -16     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BradleySappington]

looks good!

[BradleySappington]

is there a specific version we want to pin here?

[larrybradley]

The requirements.txt file in this repo pins exactly to 0.4.6, which is the latest release:

webbpsf/requirements.txt

Line 10 in b219a7d

astroquery==0.4.6

That seems very specific, but I can update this PR to use that. Internally, webbpsf is using astroquery.mast. I'm not sure if that API changes frequently.

[mperrin]

FYI @larrybradley, I agree having the "requirements" all pinned to exactly specifically the latest version is a little surprising and counterintuitive. That turns out to be from the use of Dependabot to manage dependencies. That service automatically updates the requirements.txt file to the latest versions of things. This has the nice effect of ensuring the CI runs with the latest version of every package, but on the other hand means that semantically the "requirements.txt" is not truly the minimum required version. Tradeoffs... 🤷‍♂️

[larrybradley]

There's also a discrepancy between the actual package runtime requirements as specfied in the pyproject.toml file:
https://github.com/spacetelescope/webbpsf/blob/develop/pyproject.toml#L16

and the dependencies in requirements.txt. It appears the install docs and various CI point to requirements.txt. Not sure why that is needed for CI since the latest versions will be used by default.

[BradleySappington]

The pyproject dependencies are all loosely pinned (above a certain version), while the requirements.txt are all the latest (thanks to dependabot). This gives two install options, if you install via pip with no special commands, pyproject will be used. If you want to install with the latest version only, the user can install using requirements.txt via pip install . -r requirements.txt.

[BradleySappington]

Just had a discussion with @obi-wan76, since astroquery isn't needed for base functionality, we should move the dependency down to the [project.optional-dependencies] section.

[larrybradley]

I've updated this PR to move astroquery as an optional dependency under the all variant.

[BradleySappington]

Thanks @larrybradley