Merge pull request #671 from mperrin/detector_effects_framework

Add H2RG detector effects sim framework

.github/workflows/ci_workflows.yml

@@ -58,7 +58,7 @@ jobs:
 
     - name: Get WebbPSF Data
       run: | # Get WebbPSF data files (just a subset of the full dataset!) and set up environment variable
-           wget https://stsci.box.com/shared/static/n1fealx9q0m6sdnass6wnyfikvxtc0zz.gz  -O /tmp/minimal-webbpsf-data.tar.gz
+           wget https://stsci.box.com/shared/static/ykkvequ9cbble6qg88ldhjoep4m9ey6x.gz -O /tmp/minimal-webbpsf-data.tar.gz
            tar -xzvf /tmp/minimal-webbpsf-data.tar.gz
            echo "WEBBPSF_PATH=${{github.workspace}}/webbpsf-data" >> $GITHUB_ENV
 

webbpsf/constants.py

@@ -243,3 +243,24 @@
 JWST_INSCRIBED_DIAMETER = 5.47334  # meters. Middle corners of C segments
 
 JWST_TYPICAL_LOS_JITTER_PER_AXIS = 0.0008 # milliarcseconds jitter, 1 sigma per axis. = approx 1 mas rms radial, typically
+
+
+# ad hoc, highly simplified models for charge diffusion within detectors
+# These values are PLACEHOLDERS and should be updated based on comparisons with data and ePSFs (ongoing)
+# Note, these are parameterized as arcseconds for convenience (and consistency with the jitter paramater)
+# but the underlying physics cares more about detector pixel pitch.
+INSTRUMENT_DETECTOR_CHARGE_DIFFUSION_DEFAULT_PARAMETERS = {
+    'NIRCAM_SW': 0.006,     # Fit by Marcio to WFS TA ePSFs
+    'NIRCAM_LW': 0.012,     # Scaled up by pixel pitch
+    'NIRISS': 0.028,         # Fit by Marcio to MIMF-3 F158M (ePSF)
+    'FGS': 0.07,            # Fit by Marcio to FGS_ID images
+    'NIRSPEC': 0.036,
+    'MIRI': 0.05,          # Fit by Marcio to F560W ePSF and single PSF (MIMF-3)
+                           #  0.070 Based on user reports, see issue #674. However, this is before adding IPC effects
+}
+# add Interpixel capacitance (IPC) effects. These are the parameters for each detector kernel
+# For NIRCam we  use CV3/Flight convolution kernels from Jarron Leisenring, see detectors.apply_detector_ipc for details
+# NIRISS has different kernels provided by Kevin Volk (STScI), see detectors.apply_detector_ipc for details
+INSTRUMENT_IPC_DEFAULT_KERNEL_PARAMETERS = {
+    'MIRI': (0.033, 0.024, 0.013),          # Based on JWST-STScI-002925 by Mike Engesser
+}