Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3622 Update refpix step for NIR detectors to use convolution kernel #321

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

penaguerrero
Copy link
Collaborator

Resolves JP-3622
Resolves RCAL-nnnn

Closes #

This PR addresses the changes needed to read a reference file for the NIR Optimized Convolution Kernel to be applied at the REFPIX step in the Detector1 pipeline.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@penaguerrero penaguerrero requested a review from a team as a code owner August 28, 2024 13:49
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.59%. Comparing base (fd6be8d) to head (1d3f3fe).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/stdatamodels/jwst/datamodels/conv_kernel.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   66.55%   66.59%   +0.04%     
==========================================
  Files         102      103       +1     
  Lines        5456     5469      +13     
==========================================
+ Hits         3631     3642      +11     
- Misses       1825     1827       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penaguerrero penaguerrero changed the title WIP: JP-3622 Update refpix step for NIR detectors to use convolution kernel JP-3622 Update refpix step for NIR detectors to use convolution kernel Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant