Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - sql: reduce syncv2 conn pool usage and add pool utilization metrics #6596

Closed
wants to merge 4 commits into from

sql: address review comments

260028f
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - sql: reduce syncv2 conn pool usage and add pool utilization metrics #6596

sql: address review comments
260028f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 14, 2025 in 0s

79.9% (+0.0%) compared to cdee34f

View this Pull Request on Codecov

79.9% (+0.0%) compared to cdee34f

Details

Codecov Report

Attention: Patch coverage is 99.04762% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (cdee34f) to head (260028f).
Report is 6 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sql/database.go 98.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6596   +/-   ##
=======================================
  Coverage     79.8%   79.9%           
=======================================
  Files          356     356           
  Lines        47339   47435   +96     
=======================================
+ Hits         37820   37902   +82     
- Misses        7376    7388   +12     
- Partials      2143    2145    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.