-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the description for the remaining bulk actions views #582
Conversation
Your Render PR Server URL is https://spacelift-user-documentation-pr-582.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cqu6ood6l47c73e34uq0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but take my ✅ it for what is worth 😅
My grammar is not the best, so maybe it's worth waiting for a native speaker review as usual (not dropping any name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a small grammar issue.
Other than that, one thing I wondered about is if in each section it would be worth including a screenshot to make it easier to understand the part of the application we're talking about?
@adamconnelly: Added screenshots and fixed grammar issues 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just noticed another few typos, and left a comment about the change to the oxipng command.
Description of the change
Adds the remaining bulk actions pages action descriptions
See: https://spacelift-user-documentation-pr-582.onrender.com/product/bulk-actions.html
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
main
branch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering
. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇