Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the description for the remaining bulk actions views #582

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

dnaploszek
Copy link
Contributor

@dnaploszek dnaploszek commented Aug 14, 2024

Description of the change

Adds the remaining bulk actions pages action descriptions

See: https://spacelift-user-documentation-pr-582.onrender.com/product/bulk-actions.html

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@dnaploszek dnaploszek self-assigned this Aug 14, 2024
Copy link

render bot commented Aug 14, 2024

@dnaploszek dnaploszek marked this pull request as ready for review August 14, 2024 08:39
@dnaploszek dnaploszek requested review from a team August 14, 2024 08:54
eliecharra
eliecharra previously approved these changes Aug 14, 2024
Copy link
Member

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but take my ✅ it for what is worth 😅
My grammar is not the best, so maybe it's worth waiting for a native speaker review as usual (not dropping any name).

peterdeme
peterdeme previously approved these changes Aug 14, 2024
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a small grammar issue.

Other than that, one thing I wondered about is if in each section it would be worth including a screenshot to make it easier to understand the part of the application we're talking about?

docs/product/bulk-actions.md Outdated Show resolved Hide resolved
@dnaploszek dnaploszek dismissed stale reviews from peterdeme and eliecharra via 549ca97 August 14, 2024 11:20
@dnaploszek
Copy link
Contributor Author

@adamconnelly: Added screenshots and fixed grammar issues 🫡

Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed another few typos, and left a comment about the change to the oxipng command.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
docs/product/bulk-actions.md Outdated Show resolved Hide resolved
@dnaploszek dnaploszek merged commit 1474a31 into main Aug 14, 2024
1 check passed
@dnaploszek dnaploszek deleted the bulk-actions-other-views branch August 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants