Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack deps: document new improvement #559

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

peterdeme
Copy link
Contributor

Description of the change

We need to wait until the feature is released though.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Jul 17, 2024

@peterdeme peterdeme requested a review from cube2222 July 18, 2024 10:01
@peterdeme peterdeme requested review from cube2222 and a team July 26, 2024 09:29
ilya-hontarau
ilya-hontarau previously approved these changes Jul 31, 2024
adamconnelly
adamconnelly previously approved these changes Jul 31, 2024
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than a tiny typo.

docs/concepts/stack/stack-dependencies.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Connelly <[email protected]>
@peterdeme peterdeme merged commit b7ad1ba into main Jul 31, 2024
1 check passed
@peterdeme peterdeme deleted the adjust-stack-deps-example branch July 31, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants