Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the notification policy documentation by adding the new "update PR comments in place" feature. #552

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

silviutanasa
Copy link
Contributor

@silviutanasa silviutanasa commented Jul 9, 2024

Description of the change

Updates the notification policy documentation by adding the new "update PR comments in place" feature.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Jul 9, 2024

@silviutanasa silviutanasa self-assigned this Jul 9, 2024
@silviutanasa silviutanasa force-pushed the add-docs-for-notification-policy-deduplication branch from fe53d82 to 461aa7b Compare July 9, 2024 12:50
@silviutanasa silviutanasa requested review from cube2222, sephriot and Yantrio and removed request for sephriot July 9, 2024 14:22
@silviutanasa silviutanasa force-pushed the add-docs-for-notification-policy-deduplication branch from eddd067 to 74b638d Compare July 10, 2024 09:52
@silviutanasa silviutanasa marked this pull request as ready for review July 10, 2024 09:56
@silviutanasa silviutanasa force-pushed the add-docs-for-notification-policy-deduplication branch from 74b638d to a0086c3 Compare July 10, 2024 11:24
@silviutanasa silviutanasa changed the title updates notification policy docs: adds deduplication_key info Updates the notification policy documentation by adding the new "update PR comments in place" feature. Jul 10, 2024
Yantrio
Yantrio previously approved these changes Jul 10, 2024
Copy link
Member

@Yantrio Yantrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nitpick. otherwise it's good

docs/concepts/policy/notification-policy.md Outdated Show resolved Hide resolved
@silviutanasa silviutanasa force-pushed the add-docs-for-notification-policy-deduplication branch from 4b408bf to 4460486 Compare July 11, 2024 11:49
@silviutanasa silviutanasa merged commit 226a9ee into main Jul 11, 2024
1 check passed
@silviutanasa silviutanasa deleted the add-docs-for-notification-policy-deduplication branch July 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants