-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the notification policy documentation by adding the new "update PR comments in place" feature. #552
Merged
silviutanasa
merged 1 commit into
main
from
add-docs-for-notification-policy-deduplication
Jul 11, 2024
Merged
Updates the notification policy documentation by adding the new "update PR comments in place" feature. #552
silviutanasa
merged 1 commit into
main
from
add-docs-for-notification-policy-deduplication
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://spacelift-user-documentation-pr-552.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cq6irjmehbks739kmcm0. |
fe53d82
to
461aa7b
Compare
eddd067
to
74b638d
Compare
74b638d
to
a0086c3
Compare
cube2222
reviewed
Jul 10, 2024
cube2222
reviewed
Jul 10, 2024
cube2222
reviewed
Jul 10, 2024
cube2222
reviewed
Jul 10, 2024
Yantrio
previously approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny nitpick. otherwise it's good
Yantrio
approved these changes
Jul 11, 2024
4b408bf
to
4460486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the notification policy documentation by adding the new "update PR comments in place" feature.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
main
branch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering
. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇