Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release updates: new Stack Settings, Stack Policies and Stack Scheduling #539

Merged
merged 10 commits into from
Jul 10, 2024

Conversation

rjohnep
Copy link
Contributor

@rjohnep rjohnep commented Jun 25, 2024

Description of the change

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Jun 25, 2024

@rjohnep rjohnep force-pushed the stack-settings-redesign-docs-polishsing-session_1 branch 2 times, most recently from 70be216 to 7d2d9f7 Compare July 8, 2024 15:38
@rjohnep rjohnep requested a review from a team July 8, 2024 15:39
@rjohnep rjohnep marked this pull request as ready for review July 8, 2024 15:40
adamconnelly
adamconnelly previously approved these changes Jul 9, 2024
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor suggestion.

docs/concepts/stack/deleting-a-stack.md Outdated Show resolved Hide resolved
Apollorion
Apollorion previously approved these changes Jul 9, 2024
@rjohnep rjohnep dismissed stale reviews from Apollorion and adamconnelly via 046fa13 July 9, 2024 15:30
@rjohnep rjohnep force-pushed the stack-settings-redesign-docs-polishsing-session_1 branch from 7d2d9f7 to 046fa13 Compare July 9, 2024 15:30
@rjohnep rjohnep merged commit 7d99ec5 into main Jul 10, 2024
1 check passed
@rjohnep rjohnep deleted the stack-settings-redesign-docs-polishsing-session_1 branch July 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants