Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for MFA feature #396

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add docs for MFA feature #396

wants to merge 7 commits into from

Conversation

Roma36
Copy link
Contributor

@Roma36 Roma36 commented Nov 30, 2023

Description of the change

This PR adds documentation for MFA feature.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Nov 30, 2023

@Roma36 Roma36 force-pushed the create-mfa-docs branch 2 times, most recently from db67847 to 9e64a69 Compare November 30, 2023 14:02
WSpacelifT
WSpacelifT previously approved these changes Nov 30, 2023
Copy link
Contributor

@jmfontaine jmfontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the misplaced screenshots, it looks good to me.

docs/product/security/mfa.md Outdated Show resolved Hide resolved
docs/product/security/mfa.md Outdated Show resolved Hide resolved
@Roma36 Roma36 requested a review from jmfontaine May 24, 2024 13:59
@Roma36 Roma36 marked this pull request as ready for review May 24, 2024 13:59
@Roma36
Copy link
Contributor Author

Roma36 commented May 24, 2024

@jmfontaine I have addressed your comments and rebased this branch , but for some reason, one external link is failing check:
https://git.alpinelinux.org/aports/tree/testing/spacectl/APKBUILD returns 502

Copy link
Contributor

@jmfontaine jmfontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants