Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix env var interpolation #61

Merged
merged 1 commit into from
Sep 13, 2024
Merged

ci: fix env var interpolation #61

merged 1 commit into from
Sep 13, 2024

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Sep 13, 2024

Description of the change

Unfortunately it's a bit more complicated to inject those env vars manually so we opted to Packer to just get them from the "basic" env vars.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme force-pushed the fix-env-interpolation branch 2 times, most recently from 7dcf6c2 to 6eb3923 Compare September 13, 2024 16:07
@peterdeme peterdeme marked this pull request as ready for review September 13, 2024 16:08
@peterdeme peterdeme requested a review from a team as a code owner September 13, 2024 16:08
@peterdeme peterdeme force-pushed the fix-env-interpolation branch from 6eb3923 to 8d409db Compare September 13, 2024 16:12
@peterdeme peterdeme merged commit 1316726 into main Sep 13, 2024
3 checks passed
@peterdeme peterdeme deleted the fix-env-interpolation branch September 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants