Added comparison between read and unread in Compact and Super Compact modes. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Super Compact modes.
spacecowboy
requested changes
Aug 19, 2024
Comment on lines
+214
to
+219
| // The color of unread items remains unchanged, and the color of read items increases transparency | ||
| val titleColor = if (item.unread) { | ||
| Color.Unspecified // Use the default color and do not change the color of unread items | ||
| } else { | ||
| LocalContentColor.current.copy(alpha = 0.74f) //Increase transparency of read item color | ||
| } |
There was a problem hiding this comment.
All of this should be moved inside the FeedListItemTitleTextStyle function in Typography.kt. See how the the font weight uses the unread flag:
fontWeight = titleFontWeight(item.unread)
|
Also please run |
|
Yes, yes, this change will affect all styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comparison between read and unread article titles in Compact and Super Compact modes.
In Compact and Super Compact modes, it is difficult to distinguish between read and unread articles. This PR will improve this problem.