Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microwave recipes to the guidebook #34105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add microwave recipes to the guidebook #34105

wants to merge 1 commit into from
+788 −91

Conversation

sowelipililimute
Copy link
Contributor

@sowelipililimute sowelipililimute commented Dec 28, 2024 •
edited
Loading

About the PR

Microwave recipes are now automatically listed in the guidebook.

Why / Balance

This makes discovering microwave recipes for new chefs actually possible.

Technical details

  • add GuideMicrowaveGroupEmbed and GuideMicrowaveEmbed widgets for automatically listing and displaying recipes in the guidebook
  • add Group data field to the microwave recipe prototype
  • add groups to microwave recipe prototypes
  • add new guidebook documents for the new microwave recipe groups

Media

grafik

Requirements

Breaking changes

Changelog

🆑

  • add: Added microwave cooking recipes to the guidebook

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. Changes: UI Changes: Might require knowledge of UI design or code. and removed S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Dec 28, 2024
@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: Service Area: Service department, including cooking, botany, etc A: Guidebook Area: Ingame guidebook, content or technical implementation labels Dec 28, 2024
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/microwave-recipes branch from 9942640 to 4e23c98 Compare December 28, 2024 21:00
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Dec 28, 2024
@lzk228
Copy link
Contributor

lzk228 commented Dec 28, 2024

dear god thank you🙏

Aeshus
Aeshus requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We've really been needing this...

I didn't really have much time to look into it much/give in depth feedback, but here are my initial thoughts after looking through everything.

Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.cs Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.cs Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.cs Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.cs Outdated Show resolved Hide resolved
Content.Client/Guidebook/Controls/GuideMicrowaveGroupEmbed.xaml Outdated Show resolved Hide resolved
Resources/Prototypes/Guidebook/references.yml Show resolved Hide resolved
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/microwave-recipes branch from 4e23c98 to e56fc1a Compare December 29, 2024 09:05
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 29, 2024
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/microwave-recipes branch from e56fc1a to 87fa1b2 Compare December 29, 2024 09:17
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/microwave-recipes branch from 87fa1b2 to 1bd04fe Compare January 5, 2025 07:53
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/microwave-recipes branch from 1bd04fe to 04c799d Compare January 5, 2025 08:16
@lzk228 lzk228 mentioned this pull request Jan 10, 2025
Open
@Alpaccalypse
Copy link
Contributor

Alpaccalypse commented Jan 10, 2025 •
edited
Loading

Thanks, from the title, I didn't realise just what great work you had done. This look like it should resolve #34342 I just posted.
Does this cover things like sandwiches and burgers? Do we even have sandwiches for that matter...

@sowelipililimute
Copy link
Contributor Author

this only lists microwave recipes, so e.g. construction graph recipes like the custom burgers and tacos aren't listed here

@Alpaccalypse
Copy link
Contributor

Now I think of it, they would need a hand-crafted entry anyway, as they are so open-ended. (Accidental double pun)

@Mixelz Mixelz mentioned this pull request Jan 18, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

@Aeshus Aeshus Awaiting requested review from Aeshus

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A: Guidebook Area: Ingame guidebook, content or technical implementation A: Service Area: Service department, including cooking, botany, etc Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sowelipililimute @lzk228 @Alpaccalypse @Aeshus @beck-thompson