Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor audio system to send collection IDs over the network #33610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor audio system to send collection IDs over the network #33610

wants to merge 1 commit into from
+45 −44

Conversation

sowelipililimute
Copy link

@sowelipililimute sowelipililimute commented Nov 27, 2024 •
edited
Loading

About the PR

This updates SS14 to compile with the changes made in space-wizards/RobustToolbox#5540.

Why / Balance

This is important groundwork for future features such as captioning, as a caption and other data can be associated with the collection prototype instead of passing extra data everywhere with the sound.

Technical details

Requirements

Breaking changes

  • The AudioSystems now deal in ResolvedSoundSpecifiers rather than strings as the "raw" path format. An implicit conversion from string to ResolvedPathSpecifier was added to ease the breaking nature of the changes.

Requires space-wizards/RobustToolbox#5540

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 27, 2024
@beck-thompson beck-thompson added P1: High Priority: Higher priority than other items, but isn't an emergency. T: Refactor Type: Refactor of notable amount of codebase D1: High Difficulty: Extensive codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 27, 2024
Aeshus
Aeshus reviewed Nov 27, 2024
View reviewed changes
RobustToolbox Outdated Show resolved Hide resolved
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/send-collection-ids branch 3 times, most recently from 2c635df to 12e8b8b Compare November 28, 2024 19:47
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/send-collection-ids branch from 12e8b8b to 709992b Compare December 11, 2024 19:41
@sowelipililimute sowelipililimute mentioned this pull request Dec 22, 2024
Draft
7 tasks
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/send-collection-ids branch from 709992b to c5bf409 Compare December 24, 2024 19:39
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aeshus Aeshus Aeshus left review comments

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D1: High Difficulty: Extensive codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sowelipililimute @Aeshus @beck-thompson