Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kill fellow traitor objective! #30432

Closed

Conversation

beck-thompson
Copy link
Contributor

@beck-thompson beck-thompson commented Jul 29, 2024

About the PR

Added a new traitor objective: kill fellow traitor. It should be a little less uncommon than kill target head objective (If someone has a better weight let me know. Its hard to choose 😆!)

Why / Balance

This is part of my quest to make traitors not always buddy buddy! Now when a traitor comes to "help" you there should be just a little doubt in your mind that they are actually there to help. This shouldn't be a super common objective but just enough to make people worried.

You can still target a fellow traitor in the random person kill objective which is on purpose! Not knowing someone is a traitor and having to kill them is interesting.

Got idea from: #27872

Technical details

Media

image

Changelog

🆑

  • add: New traitor objective: kill fellow traitor!

@Dutch-VanDerLinde
Copy link
Contributor

are traitors in the normal kill person pool? maybe remove them from that and replace it with this objective

@beck-thompson
Copy link
Contributor Author

beck-thompson commented Jul 29, 2024

are traitors in the normal kill person pool? maybe remove them from that and replace it with this objective

Yep they still are! As I said in the PR, I think it is interesting to still have them there as well. If people think otherwise though I'll remove em!

@DieselMohawk
Copy link
Contributor

Is this just flavor text? If so I'm all for it.

@DieselMohawk
Copy link
Contributor

DieselMohawk commented Jul 29, 2024

Oh, I see, currently this makes kill objectives more common. Unsure how that will effect gameplay over the long run.
Still cool though.

@beck-thompson
Copy link
Contributor Author

Oh, I see, currently this makes kill objectives more common. Unsure how that will effect gameplay over the long run.
Still cool though.

Yeah people don't like it being its own objective I'll just make it a flavor thing and make the text appear if the random kill objective turns out to be a traitor!

@DieselMohawk
Copy link
Contributor

Oh, I see, currently this makes kill objectives more common. Unsure how that will effect gameplay over the long run.
Still cool though.

Yeah people don't like it being its own objective I'll just make it a flavor thing and make the text appear if the random kill objective turns out to be a traitor!

Alrighty, good luck on the PR

@deltanedas
Copy link
Contributor

this doesnt make kill objectives more common, each objective group has its own weights

@DieselMohawk
Copy link
Contributor

this doesnt make kill objectives more common, each objective group has its own weights

Makes sense, thanks for the correction

@ThatOneGoblin25
Copy link
Contributor

I feel like this is going to be rough on newer traitors who are automatically more trusting of fellow syndies.
It also feels like a slight nerf to antag activity since there's now an increased chance of needing to kill other syndie.
Otherwise nice pr I think it would be funny to roll midround traitor and have to kill a syndie who failed and is in perma.

@beck-thompson
Copy link
Contributor Author

I feel like this is going to be rough on newer traitors who are automatically more trusting of fellow syndies.
It also feels like a slight nerf to antag activity since there's now an increased chance of needing to kill other syndie.

Those are both valid points! However, I don't think they will effect the game too much. For the first point, I just don't think it will happen often enough to matter (Although if it does happen it would suck I fully agree). We also can get normal kill objectives on normal crew which I feel is a very similar issue if it targets a new player.

For the second point, that's kind of one of my big ideas of doing the PR! I personally have never seen syndicates attack each other and have only seen them team up. I'm hoping this PR will at least make them think a little bit before just teaming up willy nilly.

I DO NOT want this to stop traitors helping each other / teaming up though (Just make them think a little before doing so)! If you think it might be a little to common I'll decrease the chance of it happening so this isn't a big worry.

@whateverusername0
Copy link
Contributor

you can already roll a kill objective for other traitors if you get lucky enough why make a separate one

@beck-thompson
Copy link
Contributor Author

you can already roll a kill objective for other traitors if you get lucky enough why make a separate one

That is very uncommon and also gives no indication that they are a traitor so 9/10 you will just treat it the same as a standard kill objective. This just makes it clear that they are a traitor and makes it slightly more frequent!

@Graded5
Copy link

Graded5 commented Jul 31, 2024

Love this idea, I hate the instant trust given to other syndies. Only issue I see is syndies running to sec and telling them who the other syndie is, but I personally feel like thats not a huge issue.

@beck-thompson
Copy link
Contributor Author

Only issue I see is syndies running to sec and telling them who the other syndie is, but I personally feel like thats not a huge issue.

Yeah that's a fair concern but I also toggled the option so the target has to be dead, not just left on the station! Like you said, it seems risky for the other syndicate to reveal themselves as well so I don't think it would be super common / become an issue.

For a lot of this stuff, we kind of need to see how it plays out in game to really get a feeling for if its good or bad.

@ps3moira
Copy link
Contributor

ps3moira commented Aug 1, 2024

Traitors already barely work together and this feels like it'd kill almost any incentive to try to team up with syndicates

@beck-thompson
Copy link
Contributor Author

Traitors already barely work together and this feels like it'd kill almost any incentive to try to team up with syndicates

Where I play they work together somewhat frequently (And never betray / kill each other) so I'm seeing the opposite problem as you are. I also hope this addresses the basically free automatic (and kind of forced metagamey) trust someone gets when they approach you saying they have a help objective!

Honestly though, I really think we would need to see this in game to truly see if its helpful or harmful!

@ElPidor

This comment was marked as spam.

@Golinth
Copy link
Contributor

Golinth commented Aug 13, 2024

I’d be okay with this if there was a chance for an opposite objective to spawn for the party being attacked to live and understand a syndie is hunting them. Basically worded as “You are being hunted by fellow traitor John Syndicate, Objective: Survive”

Otherwise as others have said, this basically just turns some syndies into valid sec officers that may reduce the chaos in a round, instead of increase it.

@ps3moira
Copy link
Contributor

ps3moira commented Aug 14, 2024

Pretty sure there's a upcoming PR #30198 that makes it so if you're in a certain organization, you're told to go kill that fellow traitor who is part of that enemy organization. This PR wouldn't work if you're supposed to treat people in the same organization well but suddenly get a kill goal to kill them just for being a syndicate.

@beck-thompson
Copy link
Contributor Author

I’d be okay with this if there was a chance for an opposite objective to spawn for the party being attacked to live and understand a syndie is hunting them. Basically worded as “You are being hunted by fellow traitor John Syndicate, Objective: Survive”

Otherwise as others have said, this basically just turns some syndies into valid sec officers that may reduce the chaos in a round, instead of increase it.

I don't think I quite agree with you but I would be open as long as its not 100% of the time. I really am doing this so traitors don't always feel super safe to team up together! If they always knew they were the target of a kill mission then it would defeat the purpose entirely. However, it does seem like a lot of fun if they both know! It could lead to some crazy fights.

@beck-thompson
Copy link
Contributor Author

Pretty sure there's a upcoming PR #30198 that makes it so if you're in a certain organization, you're told to go kill that fellow traitor who is part of that enemy organization. This PR wouldn't work if you're supposed to treat people in the same organization well but suddenly get a kill goal to kill them just for being a syndicate.

Its a cool PR but I can't plan for stuff that isn't merged (And its still in draft to boot!). If it ever gets merged then I'll obviously update the logic but I can't do anything until that happens. I also think the objective would still totally work if they are in the same organization! If they are in the same organization the wording would remain basically the same:
We have reason to believe that they have begun to question (the) [ORGANIZATION NAME] and need them eliminated.

If they are a different organization, it could just be like "They are part of a rival syndicate group and must be eliminated." or something.

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to do some in-game testing, but it looks good from a coding perspective (except a few small things). I will bring it up for maintainer discussion.

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Aug 26, 2024
@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Aug 26, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Aug 27, 2024
@slarticodefast
Copy link
Member

Hey, I brought this PR up for maintainer discussion and the decision is not to include it. The main reasons are the following:

  • Bad experience has been made in SS13 regarding traitor vs traitor gameplay (the internal affairs agent has been named specifically).
  • We would like to avoid having a traitor deathmatch mode and would rather see them work against the crew.
  • This objective is pretty similar to the random kill target which can already pick out other traitors anyways. The fact that they are a traitor should be kept unknown.

As such I will close this PR. However, personally I could maybe see it work in the future as part of a dynamic storyteller gamemode, in particular for situations where the round's balance has to be shifted towards the crew.

@UbaserB UbaserB removed the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.