Don't allow toggling internals while asleep #29753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
Does it fix turning internals while dead/crit too? |
Yes, it also prevents toggling while dead/crit/handcuffed/stunned. |
aspiringLich
pushed a commit
to aspiringLich/space-station-14
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes #29729
Why / Balance
The intended behavior is to not be able to interact with things while asleep.
Technical details
In the case of user == target, we will now call StartToggleInternalsDoAfter, which has a length of zero if the user is the target and the doafter will check for CanInteract.
We already have this logic for connecting internals, now it is consistent with disconnect.
Media
Changelog
fix: Internals can no longer be toggled while asleep