Gas Miner refactor #29657
Merged
Gas Miner refactor #29657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
Let me know if I should add the part about |
Mervill
commented
Jul 2, 2024
Comment on lines
-69
to
-70
| placement: | ||
| mode: SnapgridCenter |
There was a problem hiding this comment.
These are all unneeded because it's the default behavior for GasMinerBase
Partmedia
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Thanks for separating this into a separate PR. I've left a few review comments. I concur that Broken -> Idle is a breaking change, and ideally you would point that out in the breaking changes section. I plan to test locally tomorrow and merge so if you wouldn't mind addressing the nitpicks that would be great.
Content.Server/Atmos/Piping/Other/Components/GasMinerComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/Atmos/Piping/Other/Components/GasMinerComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/Atmos/Piping/Other/EntitySystems/GasMinerSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/Atmos/Piping/Other/EntitySystems/GasMinerSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/Atmos/Piping/Other/EntitySystems/GasMinerSystem.cs
Outdated
Show resolved
Hide resolved
Partmedia
added
Atmos
and removed
Status: Needs Review
Partmedia
reviewed
Jul 2, 2024
Content.Server/Atmos/Piping/Other/EntitySystems/GasMinerSystem.cs
Outdated
Show resolved
Hide resolved
Partmedia
reviewed
Jul 2, 2024
Co-authored-by: Partmedia <[email protected]>
Partmedia
reviewed
Jul 2, 2024
Content.Server/Atmos/Piping/Other/EntitySystems/GasMinerSystem.cs
Outdated
Show resolved
Hide resolved
aspiringLich
pushed a commit
to aspiringLich/space-station-14
that referenced
this pull request
Jul 21, 2024
Separate the environment check from CapSpawnAmount into GetValidEnvironment to make the code a little cleaner, and also makes these two checks independent. CapSpawnAmount and GetValidEnvironment now both have zero side-effects Broken renamed Idle to reflect its use. Broken in my mind implies that there's some method for fixing. --------- Co-authored-by: Partmedia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Lightly refactors
GasMinerSystemto prepare for a content PR making them examinable.Why / Balance
Technical details
CapSpawnAmountintoGetValidEnvironmentto make the code a little cleaner, and also makes these two checks independent.CapSpawnAmountandGetValidEnvironmentnow both have zero side-effectsBrokenrenamedIdleto reflect its use.Brokenin my mind implies that there's some method for fixing.enabledread-write though VVIdleread-only though VVMedia
Breaking changes
GasMinerComponent.BrokenrenamedGasMinerComponent.Idleto reflect its use.Changelog