Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable collision and dont stop moving when goes from crit to dead #29639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dakamakat
Copy link
Contributor

@dakamakat dakamakat commented Jul 1, 2024

About the PR

Resolves #22564
Do not disabling collision for dead mobs since we have #27905 that was the reason why mob stops moving in crit to dead

Why / Balance

Technical details

Media

2024-07-01.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
fix: mobs continue moving when turning dead state from crit and also still can collide

@dakamakat dakamakat changed the title Do not disable collision and stop moving in crit Do not disable collision and dont stop moving when goes from crit to dead Jul 3, 2024
Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead things should have collisionwake, it's an optimisation to make broadphase not die and will make the server crawl.

@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Jul 3, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when someone goes from crit to dead they stop moving
2 participants