Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jugs closeable, move chemistry entities into chemistry directory #29413

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Jun 24, 2024

Fixes #24861

About the PR

Jugs could be spilled by mice (was that changed?) and revanents. This prevents that in a way that is player-actionable. i.e skill issue.

Why / Balance

better than just forbidding it imo. But also, consistencey with other containers.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Chemical jugs are now closeable.

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 24, 2024

RSI Diff Bot; head commit 1618b8d merging into b48ac84
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Chemistry/jug.rsi

State Old New Status
jug Removed
icon Added
icon_open Added

Edit: diff updated after 1618b8d

@Brandon-Huu
Copy link
Contributor

Brandon-Huu commented Jun 24, 2024

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

@engineer-pearl
Copy link

Bonus: by closing, it is now safer to walk over spills!

@IProduceWidgets
Copy link
Contributor Author

This is gonna be super annoying to deal with. I would rather have my chems spilled then have to deal with opening the jug

If you use a syringe it just works tm.

@thebadman4662
Copy link

thebadman4662 commented Jun 24, 2024

#29139 It will still be possible to dragspill closed jugs so mouse griefers will not fell it compared to what we have now. Revs won't be able to just rightclick it though.
obraz

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

Learn to bottlemed. :trollface:

@Brandon-Huu
Copy link
Contributor

Brandon-Huu commented Jun 24, 2024

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

Learn to bottlemed. :trollface:

I do

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 2, 2024
@IProduceWidgets IProduceWidgets changed the title jugs closeable, move chemitsry entities into chemsitry directory jugs closeable, move chemistry entities into chemsitry directory Jul 18, 2024
@IProduceWidgets IProduceWidgets changed the title jugs closeable, move chemistry entities into chemsitry directory jugs closeable, move chemistry entities into chemistry directory Jul 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 25, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 25, 2024
@IProduceWidgets
Copy link
Contributor Author

Am a little sus because I merged master but didn't need to resolve anything :|

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 18, 2024
@slarticodefast
Copy link
Member

I made a PR that fixes revs and other mobs without hands being able to use the spill verb #31438
Do you think making jugs closeable is still useful regardless of that bug?

@IProduceWidgets
Copy link
Contributor Author

I can't think of any downsides, but honestly I mostly did it because the sprite has a cap already and I found it weird that we didn't add it to them when we added caps since they're the most interacted with container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revs can spill jugs
5 participants