Secret stash refractor #29396
Secret stash refractor #29396
Conversation
| } | ||
|
|
||
| [Serializable, NetSerializable] | ||
| public enum DoorVisualState : byte | ||
| public enum StashVisualState : byte |
There was a problem hiding this comment.
and this is just a bool
There was a problem hiding this comment.
I'm not quite sure what your getting at with this! This is the way I've done it in other PRs and everything I can find also does it this way. Mind giving some more detail?
|
stash prying can also be moved to its own component (ToolOpenable e.g.) in the far far future doors might use it |
|
Delta I'm not sure that using the openable component is the correct approach! I've looked at it and many of the functions are related to drinking specifically, and I would also have to basically disable like 90% of is uses (Verbs, OnActivated, examine stuff, etc...) just so the ToolOpenableSystem will be able to use the TryOpen and TryClose functions (Or have tool openable make an event or something). I could totally be wrong here but I feel like the better approach would be to just make the toolOpenableSystem independent from the openableSystem. Let me know what you think! |
|
OK I "Resolved" the issues but I didn't get a response so I'm not sure if this is the right way. This is 100% better than before and a lot cleaner but maybe not quite what ya'll want! |
github-actions
bot
added
the
Status: Needs Review
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Its starting... The evil merge conflicts 😭 |
github-actions
bot
removed
the
Merge Conflict
* First commit * Will do this in another PR! * maybe? * Moved stuff to ToolOpenableSystem because its smarter and cooler
About the PR
Added some additional functionality to the secret stash system and also removed the PottedPlantHide stuff because it is now redundant. Mainly the changes are mostly related to adding verbs to the system!
Why / Balance
Three main reasons:
1.) Adding the verbs allows you to now insert items that are used to close the stash inside of the stash.
2.) If there is ever some overlap with clicking, adding the verbs will always allow the stash to be accessible.
3.) This system allows more flexibility for some other things I want to add!
Technical details
Two things for whoever reviews this:
1.) Make sure what I did in
FoodSystemmakes sense. It makes sense to me (You are destroying the item) but I'm worried this is not quite how the event is supposed to be used.2.) The UtensilSystem that an incorrect handled boolean (I think) that was messing up with the stash so I fixed it.
Media
toilet2.mp4
pottedplant.mp4
I can't show any more on video, my computer will stop recording after 13 seconds (No idea why?) and its painful...