Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New event: Approaching unknown shuttle #24490

Merged
merged 41 commits into from
May 10, 2024

Conversation

TheShuEd
Copy link
Member

@TheShuEd TheShuEd commented Jan 24, 2024

About the PR

The game adds a series of events united by a common idea - a ship with ghostly roles is approaching the station, and the station's sensors notice it.

Views of the approaching shuttles:

  • Lone Nuke Operative: redesigned for the new system by a lone nuke ops. Gameplay is unchanged. arrives silently.
  • Lost Cargo technical: A cargo shuttle from another station lost coordinates and arrived at our station. It's a regular cargo shuttle filled with random resources and 2 ghost role as a regular cargo technical. With a 5% chance this is a traitor.
  • Traveling Cuisine. A small shuttle with 2 chefs arriving to treat the station to delicious meals. 5% traitor.
  • An escape pod. A surviving escape pod from another station coming to us. It has 1 ghost role as a random head member.
  • Clown Shuttle. 3 space clown + 3 Clownspider are coming up to prank station
  • Syndie Evacpod. 3 Syndicate cadets, unarmed and with no antagonist role on the evacuation pod find themselves at the station. This is an opportunity for a fun RP.

Why / Balance

making the cosmos more alive.
Increasing the number of interesting ghost roles.

Media

2024-01-24.22-48-38.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • add: New events added to the game: Random ships with new ghost roles can now come to the station.

@Errant-4
Copy link
Contributor

-vox traders
-vox "traders"

@Hmeister-fake
Copy link
Contributor

I think encountering unrelated/civilian ships would be cool, would make people more immersed in the idea that space is large. Heres some ideas to think about.

Interplanetary Pizza Delivery - A ship with 2 chef ghostroles, enough ingredients for like 12 pizzas, microwave and regent grinder, and 2 emergency pizza delivery crates.

Traveling Medical Ship - 2/3 ghost roles (doctors/parameds and maybe one engi?), some emergency med kits, body bags, med lockers, defib and cell charger, a cryo bed and a normal med bed and maybe a chemvend (probs too much)

Mercenary for hire ship - (finally, a use for merc gear other than drip) 1/3 Mercenary ghost roles, should all have AKM's with ammo, note explaining prices for service (for rp), EVA suits, probably some smoke/shrapnel nades. (probably not though because having armed people arrive to the station may create diet-nukie shitters.)

@Hmeister-fake
Copy link
Contributor

Also im up for mapping shuttles for this, done some cool ones in the past.

@TheShuEd
Copy link
Member Author

Any suggestions of shuttle ideas are welcome!

@MACMAN2003
Copy link
Contributor

shuttle idea: lost syndie crew shuttle: regular 9-5 syndies working for some random syndie corporation that got very, very, lost. (they don't have tc)

@Nimfar11
Copy link
Contributor

A clown troupe (2 clowns and possibly 1 mime) with a performance and a small zoo with animals including a clown spider (possibly no hostile faction).

@MACMAN2003
Copy link
Contributor

A clown troupe (2 clowns and possibly 1 mime) with a performance and a small zoo with animals including a clown spider (possibly no hostile faction).

one of those animals could be a caged urist in tider drip

@K-Dynamic
Copy link
Contributor

K-Dynamic commented Jan 24, 2024

Science ship with dangerous artifacts and actice/critted anoms

Evac shuttle empty or full of random survivors from another station

Damaged escape pod or derelict ships

Transport with cryosleeper ghost roles

Sec prison ship with botany focus

Zombie pirate ship with meat tiles and space morb (Space Pirates and Zombies reference :trollface: )

@2013HORSEMEATSCANDAL
Copy link
Contributor

Medieval shuttle with a jester and a knight

@Hmeister-fake
Copy link
Contributor

one of those animals could be a caged urist in tider drip

With recycled Spirate code? Rabid tider lol

@metalgearsloth
Copy link
Contributor

My problem with this atm is it's going to lag the server for several seconds midround which isn't good.

@LordEclipse
Copy link
Member

I actually love this idea, the non-hostile ships would need to be much much much likely though to stop the ever-present threat of external forces. Maybe one of them could be an empty ship with signs of a struggle, and a dead body.

@K-Dynamic
Copy link
Contributor

My problem with this atm is it's going to lag the server for several seconds midround which isn't good.

We don't notice outside of our shitty internet and server lagspikes :trollface:

@TheShuEd
Copy link
Member Author

Does solo nuker make the server lag?

@MarakCM
Copy link

MarakCM commented Jan 24, 2024

Maybe instead of a syndicate ship... Add a syndicate warship with 1 commander and 2 operatives with a chance of about 5%? It will look better than regular syndicate agents.
Or a ship of agitators for joining the syndicate. :trollface:

@TheShuEd
Copy link
Member Author

TheShuEd commented Jan 24, 2024

Rev endround ship (after 1 hour)
:trollface:

@Hmeister-fake
Copy link
Contributor

Maybe instead of a syndicate ship... Add a syndicate warship with 1 commander and 2 operatives with a chance of about 5%? It will look better than regular syndicate agents. Or a ship of agitators for joining the syndicate. :trollface:

that just sounds like nukies at that point, i think a syndicate ship shouldnt be the defacto bad guy ship but instead a way to RP being the enemy of the corperation without murderboning, ive had custom admin syndicate visitors on Nyano before it died and it was so fun just roleplaying with that scenario

@MarakCM
Copy link

MarakCM commented Jan 24, 2024

Maybe instead of a syndicate ship... Add a syndicate warship with 1 commander and 2 operatives with a chance of about 5%? It will look better than regular syndicate agents. Or a ship of agitators for joining the syndicate. :trollface:

that just sounds like nukies at that point, i think a syndicate ship shouldnt be the defacto bad guy ship but instead a way to RP being the enemy of the corperation without murderboning, ive had custom admin syndicate visitors on Nyano before it died and it was so fun just roleplaying with that scenario

All antags (those who are against NT) are validhunted...

@Hmeister-fake
Copy link
Contributor

Maybe instead of a syndicate ship... Add a syndicate warship with 1 commander and 2 operatives with a chance of about 5%? It will look better than regular syndicate agents. Or a ship of agitators for joining the syndicate. :trollface:

that just sounds like nukies at that point, i think a syndicate ship shouldnt be the defacto bad guy ship but instead a way to RP being the enemy of the corperation without murderboning, ive had custom admin syndicate visitors on Nyano before it died and it was so fun just roleplaying with that scenario

All antags (those who are against NT) are validhunted...

i was thinking MRP, LRP is obviously bloodthristy

@metalgearsloth
Copy link
Contributor

Does solo nuker make the server lag?

Yeah and I also don't like loneops code either.

@DrMelon
Copy link
Contributor

DrMelon commented Jan 25, 2024

Yes to all of these shuttles! Make the space station feel like an actual space station with traffic coming in at times.

@Ilya246
Copy link
Contributor

Ilya246 commented Jan 25, 2024

shuttle taken over by hostile borgs?

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jan 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label May 6, 2024
@mirrorcult mirrorcult added Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze. Feature Freeze: Priority This PR is still active and is likely able to be merged before the feature freeze on May 10. labels May 6, 2024
@mirrorcult
Copy link
Contributor

okay, ready for review again

things added/changed from original:

  • LoadoutComponent now supports RoleLoadoutPrototype, so roles spawn with job gear properly (this can be used to fix setoutfit later)
  • UnknownShuttleRule replaced with existing LoadMapRule, support for grid preloading added to LoadMapRule
    • also allows for adding antag roles to these in the future very easily
  • grid preloading is now a singleton map created at first gamemap load rather than being tied to stations
  • unknown shuttle events split into separate rules to allow for diff announcements + separate weighting
  • ran FixGridAtmos on the shuttles since the cargo one didnt have air
  • all ghostroles added have at least short raffling

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels May 8, 2024
@mirrorcult
Copy link
Contributor

mirrorcult commented May 8, 2024

after weighting changes this is roughly the incidence of these rules as well as comparison to other rules (per 1k rounds):

[INFO] CON: > stationevent:simulate 1000 80 80 20
[INFO] CON: (GasLeak, 547),
(BluespaceArtifact, 538),
(AnomalySpawn, 536),
(SolarFlare, 530),
(IonStorm, 513),
(MimicVendorRule, 478),
(BreakerFlip, 477),
(MassHallucinations, 477),
(CockroachMigration, 407),
(ClosetSkeleton, 394),
(RandomSentience, 394),
+(UnknownShuttleDisasterEvacPod, 392),
(KudzuGrowth, 390),
(GiftsMedical, 382),
(SleeperAgentsRule, 365),
(PowerGridCheck, 335),
(MouseMigration, 330),
(ClericalError, 325),
(GiftsJanitor, 307),
(GiftsPizzaPartySmall, 277),
+(UnknownShuttleCargoLost, 270),
(MeteorSwarm, 269),
(VentClog, 256),
+(UnknownShuttleTravelingCuisine, 245),
(BluespaceLocker, 243),
(SpiderSpawn, 242),
(SlimesSpawn, 240),
(NinjaSpawn, 232),
(BureaucraticError, 207),
(GiftsSpacingSupplies, 207),
(RevenantSpawn, 202),
(GiftsFireProtection, 188),
(GiftsEngineering, 185),
(DragonSpawn, 181),
(GiftsVendingRestock, 161),
(GiftsSecurityGuns, 159),
(LoneOpsSpawn, 148),
+(UnknownShuttleHonki, 145),
(GiftsSecurityRiot, 141),
+(UnknownShuttleSyndieEvacPod, 124),
(ImmovableRodSpawn, 110),
(GiftsPizzaPartyLarge, 103),
(ZombieOutbreak, 51),
(SpiderClownSpawn, 38)

@mirrorcult
Copy link
Contributor

test fail is real idk what is breaking that exactly

@mirrorcult
Copy link
Contributor

nvm fixed

@mirrorcult mirrorcult dismissed metalgearsloth’s stale review May 10, 2024 11:35

it is freeze time gotta mergey

@mirrorcult mirrorcult merged commit e522bbf into space-wizards:master May 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Freeze: Closed from May 10 to June 14 This PR is still active, but will be closed from May 10 to June 14 as part of the feature freeze. Feature Freeze: Priority This PR is still active and is likely able to be merged before the feature freeze on May 10. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.