Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Charcoal. #10042 #11024

Merged
merged 9 commits into from
Sep 10, 2022
Merged

Implement Charcoal. #10042 #11024

merged 9 commits into from
Sep 10, 2022

Conversation

WPRobson
Copy link
Contributor

@WPRobson WPRobson commented Sep 4, 2022

About the PR

Relates to #10042
Adds charcoal into the game. Charcoal will remove other chemicals from the players chemical solution at a rate of 3u per tick, but is provided as a data-field so can be adjusted later in the chemicals prototype json. Also heals poison damage at 1 per tick. Charcoal will not remove itself from the chem solution and will be metabolized normally.

Changelog
🆑 WPRobson

  • add: Added charcoal into the game. Heals poison damage and removes chemicals from the bloodstream

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 4, 2022
@Visne
Copy link
Member

Visne commented Sep 5, 2022

I kinda don't see why charcoal and carbon should be seperate things

@WPRobson
Copy link
Contributor Author

WPRobson commented Sep 5, 2022

The effect could be easily moved to carbon if decided that is better @moonheart08 originally created that issue maybe they have something to say about it?

@moonheart08
Copy link
Contributor

Charcoal is a separate thing but it also shouldn't be directly dispensable. Do we have ash yet? If yes, recipe should be ash + carbon, if no i'll think of something in a bit.

@WPRobson
Copy link
Contributor Author

WPRobson commented Sep 5, 2022

Looks like we do have ash. Or at least I saw spawn it in a dev environment. So I can remove it from the dispenser and make it into a recipe

@WPRobson
Copy link
Contributor Author

WPRobson commented Sep 5, 2022

although saying that #10373 looks like it was meant to provide a way of easily making ash and that's not merged yet

@EmoGarbage404
Copy link
Member

Looks like we do have ash. Or at least I saw spawn it in a dev environment. So I can remove it from the dispenser and make it into a recipe

we have ash as an entity. It's gotten from crematoriums. Ideally, there'd be a better way of acquiring it.

@WPRobson
Copy link
Contributor Author

WPRobson commented Sep 5, 2022

@moonheart08 Should ash now be addable to beakers directly, so that it can be fed into the chem master? or should it be something like using the grinder to grind the ash into a beaker like plasma?

@moonheart08
Copy link
Contributor

@moonheart08 Should ash now be addable to beakers directly, so that it can be fed into the chem master? or should it be something like using the grinder to grind the ash into a beaker like plasma?

Addable directly. Look at how eggs work I think?

@WPRobson
Copy link
Contributor Author

@moonheart08 Ok finally figured out how to get the new recipe working and make it so ash can be spiked and used

@moonheart08 moonheart08 merged commit 7accbcb into space-wizards:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants