Project Zero Warnings

[PJB3005]

Description

The game produces a ton of compiler warnings when built right now:

This has gradually piled up over years of development to RT and SS14, primarily due to deprecation of old APIs.

Incrementally cleaning up the code to remove these warnings is something any contributor can do in small batches. Contributions appreciated!

For MOTIVATIONAL REASONS, if want to track our progress, we have a public Grafana dashboard that tracks the repo's total warning count over time!

[thetolbean]

Can we assume then that maintainers are going to be more focused on preventing PR's from introducing more warnings?

[PJB3005]

Can we assume then that maintainers are going to be more focused on preventing PR's from introducing more warnings?

My current stance is that PRs adding warnings isn't big enough of a deal to warrant the effort to implement an automatic CI enforcement system like that. Best to just fix all the warnings right now.

[benev0]

I have a branch open for updating the static logger to sawmill. It will probably be in later this week

[benev0]

I have a branch open for updating the static logger to sawmill. It will probably be in later this week

segfaulting is a concern with the non-static logger due to nullable annotation being incorrect; this will take longer than expected.