Replace obsolete TransformComponent.Anchored set #5548
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bro got got by the exact same thing that made me skip out on fixing these warnings |
|
AnchorEntity is not a drop-in replacement because the anchored setter does the slow-path of tryfindgridat. |
I'll add additional condition then to keep old behaviour for cases like this |
It reparents and rises move event, that were not used in obsolete setter
Comment on lines
+127
to
+133
| { | ||
| if (!_mapManager.TryFindGridAt(GetMapCoordinates(entity.Comp), out var gridUid, out var gridMapComp)) | ||
| return false; | ||
| grid = (gridUid, gridMapComp); | ||
| } | ||
| else | ||
| grid = (entity.Comp.GridUid.Value, gridComp); |
There was a problem hiding this comment.
This one I'm a bit suss on because it will fallback to the slowpath where previously it would just return false. Ideally this shouldn't even be happening because the entity itself should already have a griduid.
… into 04-12-2024-obsolete-anchored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #33279
This PR also adds new condition to the AnchorEntity for case when MapGridComponent is null.