-
Notifications
You must be signed in to change notification settings - Fork 249
Medical design doc(s) #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical design doc(s) #510
Conversation
Github actions keeps removing "design" from my design doc :( |
That's because you're not modifying any files inside a proposals directory: Line 15 in c5adc48
|
sadge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fairly sleep deprived review
Address reviews
Overall I do like the medical design document - it gives a decent vision for how the system should feel. |
Co-authored-by: opl- <[email protected]>
Co-authored-by: opl- <[email protected]>
src/en/space-station-14/departments/medical/medical-workgroup.md
Outdated
Show resolved
Hide resolved
src/en/space-station-14/departments/medical/medical-workgroup.md
Outdated
Show resolved
Hide resolved
Changed all instances of psycho-med to disco-med due to rename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's very good! There's was only two lines which caused me any confusion.
> And most important, if someone really wants you dead then medical shouldn't be able to reverse that easily. | ||
> Round removal is an important part of round progression, and the threat an antagonist poses to the crew is directly linked to the damage they can do and how difficult it is to reverse it. An antagonist should be able to intentionally and permanently remove a target from the round and the station will have to manage that loss in the same way they might lose a machine or valuable item important to the station. | ||
### Pillar 2: Damage shouldn't just be flavor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pillars have a period at the end, while others don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this lays a pretty strong outline for how the medical department looks. The language is clear and doesn't cause any confusion, and overall the design described is a medbay I would like to play in.
I have made two documents in related to the (currently un)official medical workgroup.
The documents comprise of a general overview of what medical gameplay should look like from an overarching design standpoint, and a second which goes over the goals and responsibilities of the medical workgroup.
I saw it as important to include the latter since due to the current and unique nature of medical development, we need a bit more freedom in terms of managing, merging, freezing, and closing medical related PRs than a design doc would offer. It also clearly outlines the scope of what we're doing so if people have questions they can get answers, and if people want to contribute they can know what they can contribute to and how.