Toolshed coding conventions #210
Conversation
| - Toolshed commands should be all lowercase without underscores. | ||
| Example: `station:largestgrid` | ||
| NOT: `station:largest_grid`, `station:largestGrid` |
There was a problem hiding this comment.
can we fix everything to use snake_case instead for readability reasons, thanks.
There was a problem hiding this comment.
I agree snake_case would help with readability. I based these conventions of what was more common, since I only found a single case of a command being snake_case.
Toolshed currently uses all lowercase when autogenerating command name from the class name, so this would have to be changed, along with renaming all subcommands and updating docs.
There was a problem hiding this comment.
I agree snake_case would help with readability. I based these conventions of what was more common, since I only found a single case of a command being snake_case.
Toolshed currently uses all lowercase when autogenerating command name from the class name, so this would have to be changed, along with renaming all subcommands and updating docs.
yes, i know what toolshed does; i wrote it and I was wrong and would much prefer we fix that.
Adds coding conventions for toolshed. There are a few inconsistencies I've noticed, which this PR will standardize:
Commandsnamespace/directory, some in aToolshednamespace/directory, and some are just put directly underContent.Server/Whatever.stations:rerollBounties) or snake_case (physics:angular_velocity).player:list) and some use plural (stations:list).