Add proxy options #144
Open
Add proxy options #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, our launcher loads endlessly, and since this function is in SETTINGS, it’s impossible to get there. Can this be fixed? |
PJB3005
reviewed
Mar 31, 2024
SS14.Launcher/HappyEyeballsHttp.cs
Outdated
| @@ -16,7 +17,7 @@ public static class HappyEyeballsHttp | |||
| // This is the workaround. | |||
| // | |||
| // Implementation taken from https://github.com/ppy/osu-framework/pull/4191/files | |||
| public static HttpClient CreateHttpClient(bool autoRedirect = true) | |||
| public static HttpClient CreateHttpClient(bool autoRedirect = true, String ?proxyURL = null) | |||
There was a problem hiding this comment.
Suggested change
| public static HttpClient CreateHttpClient(bool autoRedirect = true, String ?proxyURL = null) | |
| public static HttpClient CreateHttpClient(bool autoRedirect = true, string? proxyURL = null) |
Formatting nit.
SS14.Launcher/HappyEyeballsHttp.cs
Outdated
| { | ||
| WebProxy webProxy = new WebProxy(proxyURL); | ||
| Uri proxyURLUri = new Uri(proxyURL); | ||
| Log.Debug(proxyURLUri.UserInfo); |
There was a problem hiding this comment.
Printing password to log is a very bad idea, comment this out.
Comment on lines
58
to
64
| <Grid ColumnDefinitions="Auto,*"> | ||
| <CheckBox VerticalAlignment="Center" Margin="4" IsChecked="{Binding ProxyEnable}">Enable proxy</CheckBox> | ||
| <TextBox Grid.Column="1" Watermark="http://example.com:80" Text="{Binding ProxyURL}" /> | ||
| </Grid> | ||
| <TextBlock VerticalAlignment="Center" TextWrapping="Wrap" | ||
| Text="Proxy information for connect to hub and auth center." | ||
| Margin="8" /> |
There was a problem hiding this comment.
This should communicate that changing proxy settings requires launcher restart.
Comment on lines
+31
to
+32
| WebProxy webProxy = new WebProxy(proxyURL); | ||
| Uri proxyURLUri = new Uri(proxyURL); |
There was a problem hiding this comment.
What happens if the proxy settings are malformed (invalid URL)? Does it cause the launcher to get stuck crashing on startup with broken config?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support using HTTP proxy for API requests
Allow enter address with credentials (ex. http://username:[email protected]:3128)