Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sentry into the launcher #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

juliangiebel
Copy link
Contributor

@juliangiebel juliangiebel commented Jan 23, 2024

Exception will get sent to the sentry instance the set DSN is from.
The Sentry integration can be enabled and disabled using a cvar as well as the DSN is set using a cvar.
image
This dialog gets shown when the launcher is started and the user hasn't seen the dialog yet:
image
This is the form that gets shown when an error happens in the launcher:
image

image

A Sentry instance needs to be set up and the DSN needs to be added to the launcher config

TODO:

@Visne
Copy link
Member

Visne commented Jan 23, 2024

Might be worth considering to set up a GlitchTip instance instead of Sentry, considering that it should be compatible with the Sentry SDK, is actually open source, and doesn't try weird shit like this (now retracted).

@juliangiebel
Copy link
Contributor Author

I'm using glitch tip at work and it's sadly a bugy mess that has a tenth of the capabilities of sentry.

@juliangiebel juliangiebel marked this pull request as ready for review January 27, 2024 22:12
@juliangiebel
Copy link
Contributor Author

The texts that get shown in the dialog boxes are probably not good enough so feel free to suggest what I should write instead.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants