Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocus connect button on press #111

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Visne
Copy link
Member

@Visne Visne commented Nov 1, 2023

Fixes #86

After clicking Connect the connect button would still be focused and if you pressed Space/Enter you would trigger the connect again, causing an exception and crashing the client. Now we just unfocus right after the button is clicked so that that's no longer possible.

@PJB3005
Copy link
Member

PJB3005 commented Nov 2, 2023

I'd prefer if there was a better way to do this with some input context system or something. I think Avalonia v10 had some faint whispers but they got removed in v11. Ah well.

@PJB3005 PJB3005 merged commit 21800a1 into space-wizards:master Nov 2, 2023
2 checks passed
@Visne Visne deleted the connectbutton branch November 2, 2023 00:29
Skyedra pushed a commit to Skyedra/SS14.Launcher that referenced this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update already in progress crash
2 participants