Make colour equality not approximate #5253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
force-pushed
the
color-equality
branch
from
7b2c03d
to
eeca1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the colour equality methods use
MathHelper.CloseToPercent()instead of actually checking equality, which directly contradicts the method's own documentation. IMO equality should just check equality. If approximate equality is desired, that should be explicitly checked.I'm not sure why exactly it was using approximate equality before. Maybe it was trying to avoid unnecessary shader/rendering changes? In which case maybe this PR should also update those checks.