Add an entry to RSI meta.json for controlling RSI atlas grouping #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
commented
Jun 18, 2024
Comment on lines
+188
to
+194
| }, | ||
| "atlasGroup": { | ||
| "$id": "#/properties/atlasGroup", | ||
| "default": "", | ||
| "description": "An integer that is used to group RSIs into the same texture atlas. Defaults to 0. Negative values prevent the RSI from being put into a larger atlas.", | ||
| "title": "atlasGroup", | ||
| "type": "integer" |
There was a problem hiding this comment.
I'm not really sure how the RSI schema validator works, but hopefully this is right?
This was referenced Jun 18, 2024
PJB3005
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an "atlasGroup" integer to the RSI meta.json that is intended to allow RSIs to try and control how they are inserted into the RSI atlases. Currently this doesn't actually ensure that each "group" has its own atlas, but ideally that's what it would do eventually (rectangle packing when). Currently its mainly useful for trying to prevent large & niche RSIs from taking up space in the main atlas.