Add sourcegenned field deltas #5155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrSmugleaf
reviewed
May 20, 2024
| @@ -35,7 +35,8 @@ END TEMPLATE--> | |||
|
|
|||
| ### Breaking changes | |||
|
|
|||
| *None yet* | |||
| * The `ComponentState` class is now abstract. Networked components that don't have state information now just return a null state. | |||
| * The way that delta component states work has changed. It now expects there to be two different state classes, only one of which should implement `IComponentDeltaState<TFulState>` | |||
There was a problem hiding this comment.
Minor spelling mistake
Suggested change
| * The way that delta component states work has changed. It now expects there to be two different state classes, only one of which should implement `IComponentDeltaState<TFulState>` | |
| * The way that delta component states work has changed. It now expects there to be two different state classes, only one of which should implement `IComponentDeltaState<TFullState>` |
There was a problem hiding this comment.
review the other pr you absolute fool
…deltas # Conflicts: # Robust.Shared/GameObjects/ComponentState.cs
…deltas # Conflicts: # Robust.Shared/GameObjects/Components/Eye/EyeComponent.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was easiest thing to do and some stuff like physics + solutions + transform will need their own solutions but this makes generic stuff like hunger, guns, thirst easier. It's also setup so it shouldn't be too hard to do field deltas for transform / physics in a generic way for some stuff.
The other benefit is we can network a lot more stuff (e.g. VVable fields) and not worry about states bloating out.
Branched from electro's delta branch.
One thing I'm not sure on is how to handle backwards compatibility short of making every single dirty call a field-level one for a component.
I checked out net_graph and there is a noticeable drop for hunger + thirst but not sure how else to profile it (obviously CPU wise I expect it would be slower marginally, just due to having to check if it's a delta state or not). With that being said if it's like a single bool component or small it's probably faster to just do a full dirty and not use deltas due to the List overhead (though not sure how it gets serialized).
On master the 2 spikes go up to the same point but with field deltas one noticeably drops a lot.
Okay so I measured it:
477 payload size vs 97 for 4 hunger states. Gun states went down by ~80 per state. Most of the time it's not going to be worth it but if we know there's a big component state like guns or something else that updates frequently (e.g. UI component) or something we can do specific implementations for in hotpaths (i.e. transform and physics with specific deltas without the List<T> overhead) then it'll give big savings.