Skip to content

Upstream sync

Upstream sync #4767

Triggered via pull request August 30, 2024 05:41
@Morb0Morb0
synchronize #2534
upstream-sync
Status Success
Total duration 7m 19s
Artifacts

test-packaging.yml

on: pull_request
Test Packaging
7m 8s
Test Packaging
Fit to window
Zoom out
Zoom in

Annotations

32 warnings
Test Packaging
The following actions uses node12 which is deprecated and will be forced to run on node16: space-wizards/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test Packaging
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], space-wizards/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test Packaging: RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
Test Packaging: RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
Test Packaging: RobustToolbox/Robust.Shared/Containers/ContainerSlot.cs#L75
'Logger.Warning(string)' is obsolete: 'Use ISawmill.Warning'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L226
'BoundUserInterface.DeferredClose' is obsolete
Test Packaging: RobustToolbox/Robust.Shared/Physics/ComponentTreeEntry.cs#L16
'IComponent.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/QuantityTypeParser.cs#L67
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L46
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test Packaging: RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
Test Packaging: RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L46
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L57
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/QuantityTypeParser.cs#L67
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/PrototypeTypeParser.cs#L72
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
Test Packaging: RobustToolbox/Robust.Shared/Toolshed/TypeParsers/Math/SpanLikeTypeParser.cs#L100
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
Test Packaging: RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
Test Packaging: RobustToolbox/Robust.Shared/ProfileOptSetup.cs#L16
Unreachable code detected
Test Packaging: RobustToolbox/Robust.Shared/Player/Filter.cs#L289
'EntitySystem.TryGet<T>(out T?)' is obsolete: 'Either use a dependency, resolve and cache IEntityManager manually, or use EntityManager.System<T>()'
Test Packaging: RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L226
'BoundUserInterface.DeferredClose' is obsolete
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
Test Packaging: RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L407
'BoundUserInterface.DeferredClose' is obsolete
Test Packaging: RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L458
'BoundUserInterface.DeferredClose' is obsolete
Test Packaging: RobustToolbox/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs#L72
The variable 'defaultErrorOccurred' is assigned but its value is never used