Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NASA Challenge_[@damianphim]_[Update Documentation] (closes #34) #37

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

damianphim
Copy link

Closes #34

Demo and First-Time Building Overhaul

Previously, there was no documentation for any of the demos and the Space ROS documentation was outdated, so it took me like 3 days (embarrassing I know) to just build and get the demos running without any errors.

This PR updates the First-Time Building Space ROS page in the documentation (Tutorials -> First-Time Building Space ROS) to the latest method. In addition, it adds documentation for building and running MoveIt2, the Canadarm Demo, and the Curiosity Mars Rover demo.

I'm hoping this PR helps any future contributors not run into the same wall that I did!

…tructions for the Canadarm and Curiosity Mars Rover demos, and updated First-Time Build Tutorial
@130s
Copy link

130s commented Sep 11, 2024

it took me like 3 days (embarrassing I know) to just build and get the demos running without any errors.

Not just you, I spent a day and haven't been able to see Mars rover on a simulator yet :/

I see this PR is updating .rst files. I asked why space_ros uses rst space-ros/space-ros#210 (I'm not against it, it just raises hurdle IMO).

@damianphim
Copy link
Author

Not just you, I spent a day and haven't been able to see Mars rover on a simulator yet :/

Sounds like you made more progress than me on my first day, don't give up!

I see this PR is updating .rst files. I asked why space_ros uses rst space-ros/space-ros#210 (I'm not against it, it just raises hurdle IMO).

I believe the ROS 2 documentation also uses .rst files, which could be it.

@damianphim damianphim force-pushed the add-demo-documentation branch from 1b8bb56 to 1b8a062 Compare September 12, 2024 19:58
@Bckempa Bckempa self-requested a review September 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Update First-Time Build Tutorial
3 participants