Add simulation repo to demo workspace for the nav2 demo (#201) #202
Conversation
|
@xfiderek you most recently poked at this, do you think this is actually necessary? |
|
Hey @eholum. In general the demo should be working fine (you should be able to control rover with nav2 via RVIZ), but I believe you mean that the rover's URDF visualization is not present in rviz, right? Indeed, that won't work in the current state. To make it work you could run rviz from space_robots container, but then you won't be able to use nav2 plugin. In general I'm planning to rework the nav2_demo, so that rviz container is completely separate from the nav2 container (as part of space-ros/demos#28). We could upload simulation assets to the rviz container then. If you urgently need this feature I am personally fine with merging it, but otherwise maybe it makes sense to first carve out rviz. What do you think? |
Yeah that's exactly right. I was just expecting it to render and it didn't, it's a low priority, but since we're wrapping up the humble release it's just a "nice to have" to make the released version slightly more complete. |
|
Closing this given the discussion above. |
Resolves #201
Not sure how much this matters, but the rover doesn't show up in the nav2 rviz panel because the simulation resources are not available in the demo container. I also hate to add more vcs repos to our toolsets, but figured this was simplest since every other demo is built in the same way.