-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for markdown file input #93
base: main
Are you sure you want to change the base?
Conversation
Removed audio transcript files from tests. |
Great! I'll merge it as soon as I'm back at keyboard later this week.
…On Mon, Oct 21, 2024, 7:28 PM tkhongsap ***@***.***> wrote:
Removed audio transcript files from tests.
—
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADTMY3KDQYTK3PSF7SOEGLTZ4VWYRAVCNFSM6AAAAABQJYBBRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXG42TOMJTGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests on github don't pass because you forgot to add some mock data. At least the following:
tests/data/mock/website.md and
tests/data/mock/file.txt
@souzatharsis Apologies for the delay, I was out of town. I’ve updated the tests as requested and added the necessary mock data files. All tests passed successfully on my side with pytest. Here’s a summary of the test results:
|
Fix inconsistent use of tabs and spaces in indentation
Hi Pytest tests failed. ModuleNotFoundError: No module named 'markdown' Could you please review? |
@souzatharsis Hi there,
|
Hi, I recommend instead integration with https://github.com/DS4SD/docling Improved support, maintainability as well as coverage of courses since docling supports (PDF, DOCX, PPTX, Images, HTML, AsciiDoc, Markdown) There is an open issue for that if you are excited about it #138 |
Hi there,
I hope this works this time.
I ran I ran " poetry run pytest" and had no errors;