fixing up style, updating test harness

.rubocop.yml

@@ -1,16 +1,23 @@
-AllCops:
-  Excludes:
-    - vendor/**
-
 AlignParameters:
   Enabled: false
-Documentation:
-  Enabled: false
+
 Encoding:
   Enabled: false
-HashSyntax:
-  Enabled: false
+
 LineLength:
-  Enabled: false
+  Max: 200
+
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
 MethodLength:
   Max: 30
+
+CyclomaticComplexity:
+  Max: 16
+
+ParameterLists:
+  Enabled: false
+
+ClassLength:
+  Max: 117

libraries/provider_lvm_logical_volume.rb

@@ -152,7 +152,6 @@ def device_formatted?(device_name, fs_type)
           blkid = shell_out("blkid -o value -s TYPE #{device_name}")
           blkid.exitstatus == 0 && blkid.stdout.strip == fs_type.strip
         end
-
     end
   end
 end

spec/default_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'lvm::default' do
   let(:chef_run) do
-    ChefSpec::ChefRunner.new(:platform => 'ubuntu', :version => '12.04').converge('lvm::default')
+    ChefSpec::Runner.new(:platform => 'ubuntu', :version => '12.04').converge('lvm::default')
   end
 
   it 'installs lvm2' do

spec/spec_helper.rb

@@ -1,7 +1,2 @@
-require 'berkshelf'
 require 'chefspec'
-
-Berkshelf.ui.mute do
-  berksfile = Berkshelf::Berksfile.from_file('Berksfile')
-  berksfile.install(path: 'vendor/cookbooks')
-end
+require 'chefspec/berkshelf'

test/fixtures/cookbooks/fake/libraries/helper.rb

@@ -18,6 +18,7 @@
 #
 
 module LvmTest
+  # Helper definitions for lvmtest
   module Helper
     # Creates given loop devices
     #

test/fixtures/cookbooks/fake/recipes/create.rb

@@ -41,7 +41,7 @@
   logical_volume 'logs' do
     size        '10M'
     filesystem  'ext2'
-    mount_point location: '/mnt/logs', options: 'noatime,nodiratime'
+    mount_point :location => '/mnt/logs', :options => 'noatime,nodiratime'
     stripes     2
   end