EXP: try out lower level pyo3 API #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
…water into branch_api_2
…water into branch_api_2
…water into branch_api_2
4 tasks
…water into fix_skip_test
…water into refactor_gather_csv
…water into factor_out_rust_api
This reverts commit 660b17f.
…water into factor_out_rust_api
ctb
added a commit
that referenced
this pull request
Jan 7, 2025
…onality (#569) * refactor CSV output for fastgather/fastmultigather to use mpsc * cargo fmt * tests mostly pass * fix skipmer test * upd comment * black * switch to min_max_scaled for rocksdb * black * ensure overlap is > 0 * rm print * cleanup * fix clippy messages about too-complex returns * cargo fmt * separate out Rust API changes from #552 * upd overlap * fix * fix * remove remaining Box/error stuff * remove remaining join => Err * clean up error handling a bit * refactor out loading of sketches * fix tests * update docs * upd * break test again * do heinous dev stuff * fix fix comment * upd * upd * do not require -o after all * fix for crate_empty_results * fmt * remove @ctb notes * remove obligatory clone from Rust layer
…water into branch_api_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started from #428, and is working (potentially long term 😅 ) to add an intermediate container-level pyo3-based Python API into the branchwater plugin.
TODO: