Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i): Handle collection commits over P2P #3247

Merged

PR FIXUP - Note node in update cid descriptions

8a9f166
Select commit
Loading
Failed to load commit list.
Merged

feat(i): Handle collection commits over P2P #3247

PR FIXUP - Note node in update cid descriptions
8a9f166
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

77.58% (+0.04%) compared to 8e24ee4

View this Pull Request on Codecov

77.58% (+0.04%) compared to 8e24ee4

Details

Codecov Report

Attention: Patch coverage is 91.79104% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (8e24ee4) to head (8a9f166).

Files with missing lines Patch % Lines
net/server.go 74.19% 6 Missing and 2 partials ⚠️
internal/db/merge.go 95.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3247      +/-   ##
===========================================
+ Coverage    77.54%   77.58%   +0.04%     
===========================================
  Files          382      382              
  Lines        35263    35301      +38     
===========================================
+ Hits         27344    27386      +42     
+ Misses        6291     6290       -1     
+ Partials      1628     1625       -3     
Files with missing lines Coverage Δ
internal/db/messages.go 100.00% <100.00%> (ø)
net/peer.go 76.35% <100.00%> (+0.24%) ⬆️
internal/db/merge.go 82.32% <95.71%> (+1.40%) ⬆️
net/server.go 73.26% <74.19%> (-0.02%) ⬇️

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e24ee4...8a9f166. Read the comment docs.

---- 🚨 Try these New Features: