Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Remove flakyness of AES decrypt test #3241

Merged

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #3240

Description

This PR fixes a flaky test where the modification of the cypher text was supposed to cause it to fail decryption. The modification turned out to sometime be the same as the actual cypher text.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).

How has this been tested?

Run the TestDecryptAES test.

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added bug Something isn't working area/testing Related to any test or testing suite labels Nov 14, 2024
@fredcarle fredcarle added this to the DefraDB v0.15 milestone Nov 14, 2024
@fredcarle fredcarle requested a review from a team November 14, 2024 20:18
@fredcarle fredcarle self-assigned this Nov 14, 2024
Copy link
Contributor

@islamaliev islamaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (198454b) to head (220d5cb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3241      +/-   ##
===========================================
+ Coverage    77.53%   77.55%   +0.02%     
===========================================
  Files          382      382              
  Lines        35263    35263              
===========================================
+ Hits         27340    27347       +7     
+ Misses        6297     6292       -5     
+ Partials      1626     1624       -2     
Flag Coverage Δ
all-tests 77.55% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198454b...220d5cb. Read the comment docs.

@fredcarle fredcarle force-pushed the fredcarle/fix/3240-aes-decrypt-test branch from db8c7da to 220d5cb Compare November 14, 2024 21:01
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the comment :)

@fredcarle fredcarle merged commit 8e24ee4 into sourcenetwork:develop Nov 15, 2024
42 of 43 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/3240-aes-decrypt-test branch November 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky AES decrypt test
3 participants