fix: we use sslmode not pgsslmode in the deploy repos

[Chickensoupwithrice]

@marcleblanc2 pointed this out: https://linear.app/sourcegraph/issue/REL-638/configure-aws-rds-databases-for-tls-connections-in-helm-chart

Pull Request approval

You will need to get your PR approved by at least one member of the Sourcegraph team. For reviews of docs formatting, styles, and component usage, please tag the docs team via the #docs Slack channel.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sourcegraph-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 20, 2025 6:51pm

[jdpleiness]

Are we sure about that? I'm seeing this used a lot: https://sourcegraph.sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+PGSSLMODE&patternType=keyword&sm=0

[Chickensoupwithrice]

ahhh, fuck 🤔

[marcleblanc2]

I think the Helm chart values key is .sslmode, but the env vars are PGSSLMODE? Point kinda illustrated here, one of the results from Jacob's search.

[Chickensoupwithrice]

Yeah, I think I actually need to change the helm values file.

Strange that it worked in my testing though? 🤔

[marcleblanc2]

Hm, I'm curious how it'd have worked?

…

Message ID: ***@***.***>

[Chickensoupwithrice]

It works because the there's a helper template that applies a prefix

On second thought, the docs need to reflect the difference between helm chart and env var? Need to think about this more.

[marcleblanc2]

• Sure, docs specific to the env var name should match the env var name
• In this case, I'm pointing out the docs specific to the Helm override values should match the Helm chart template, as per my comment here 🙏 which looks like just a handful 🎉 . lol, this search includes a couple files I've committed to a different repo based on the docs I copy / pasted from, I'll go fix those, and communicate to the affected customers.

Key = pgsslmode

Current docs:

apiVersion: v1
kind: Secret
...
data:
...
  pgsslmode: "require" # optional, enable if using SSL

Example README.md

Key = sslmode

Current Helm template helper function:

- name: {{ printf "%sSSLMODE" $prefix }}
  valueFrom:
    secretKeyRef:
      key: sslmode
      name: {{ $secretName }}

Current Helm chart pgsql secret template

{{- if not .Values.pgsql.auth.existingSecret }}
apiVersion: v1
kind: Secret
...
data:
...
  sslmode: {{ .Values.pgsql.auth.sslmode | toString | b64enc | quote }}

[MaedahBatool]

LGTM @Chickensoupwithrice feel free to merge. :)

[marcleblanc2]

AFAIA, there needs to be a different xSSLMODE env var for each database, matching the same prefix as the other env vars for the same db.

The Helm values key, however is sslmode

The docs must match this.

[Chickensoupwithrice]

Thank you @marcleblanc2 🙏🏽 I addressed your comments

addressed comments